Skip to content
Snippets Groups Projects
Commit 12ad15b0 authored by Russell Jancewicz's avatar Russell Jancewicz
Browse files

remove extra kadmin incref statements -- TODO: review reference counting.

parent 760e9f45
No related branches found
No related tags found
No related merge requests found
...@@ -978,7 +978,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_name(PyKAdminObj ...@@ -978,7 +978,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_name(PyKAdminObj
} }
} }
Py_INCREF(principal);
return principal; return principal;
} }
...@@ -1001,7 +1000,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_db_entry(PyKAdmi ...@@ -1001,7 +1000,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_db_entry(PyKAdmi
} }
} }
Py_XINCREF(principal);
return principal; return principal;
} }
......
...@@ -347,7 +347,6 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args) ...@@ -347,7 +347,6 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_creds"); } if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_creds"); }
Py_XINCREF(kadmin);
return kadmin; return kadmin;
} }
...@@ -356,6 +355,7 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args) ...@@ -356,6 +355,7 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args) { static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args) {
PyKAdminObject *kadmin = PyKAdminObject_create(); PyKAdminObject *kadmin = PyKAdminObject_create();
PyObject *db_args_dict = NULL; PyObject *db_args_dict = NULL;
kadm5_ret_t retval = KADM5_OK; kadm5_ret_t retval = KADM5_OK;
krb5_error_code code = 0; krb5_error_code code = 0;
...@@ -404,9 +404,6 @@ static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args) ...@@ -404,9 +404,6 @@ static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args)
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_skey"); } if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_skey"); }
Py_XINCREF(kadmin);
return kadmin; return kadmin;
} }
...@@ -444,7 +441,6 @@ static PyKAdminObject *_kadmin_init_with_password(PyObject *self, PyObject *args ...@@ -444,7 +441,6 @@ static PyKAdminObject *_kadmin_init_with_password(PyObject *self, PyObject *args
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_password"); } if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_password"); }
Py_XINCREF(kadmin);
return kadmin; return kadmin;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment