From 12ad15b025868c1e4e11603f61d3918fd5cf0b05 Mon Sep 17 00:00:00 2001
From: Russell Jancewicz <russell.jancewicz@gmail.com>
Date: Mon, 30 Mar 2015 22:44:34 -0400
Subject: [PATCH] remove extra kadmin incref statements -- TODO: review
reference counting.
---
PyKAdminPrincipalObject.c | 2 --
kadmin.c | 6 +-----
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/PyKAdminPrincipalObject.c b/PyKAdminPrincipalObject.c
index c51e923..b23275a 100644
--- a/PyKAdminPrincipalObject.c
+++ b/PyKAdminPrincipalObject.c
@@ -978,7 +978,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_name(PyKAdminObj
}
}
- Py_INCREF(principal);
return principal;
}
@@ -1001,7 +1000,6 @@ PyKAdminPrincipalObject *PyKAdminPrincipalObject_principal_with_db_entry(PyKAdmi
}
}
- Py_XINCREF(principal);
return principal;
}
diff --git a/kadmin.c b/kadmin.c
index 4c85c78..93f1648 100644
--- a/kadmin.c
+++ b/kadmin.c
@@ -347,7 +347,6 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_creds"); }
- Py_XINCREF(kadmin);
return kadmin;
}
@@ -356,6 +355,7 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args) {
PyKAdminObject *kadmin = PyKAdminObject_create();
+
PyObject *db_args_dict = NULL;
kadm5_ret_t retval = KADM5_OK;
krb5_error_code code = 0;
@@ -404,9 +404,6 @@ static PyKAdminObject *_kadmin_init_with_keytab(PyObject *self, PyObject *args)
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_skey"); }
-
-
- Py_XINCREF(kadmin);
return kadmin;
}
@@ -444,7 +441,6 @@ static PyKAdminObject *_kadmin_init_with_password(PyObject *self, PyObject *args
if (retval != KADM5_OK) { PyKAdmin_RETURN_ERROR(retval, "kadm5_init_with_password"); }
- Py_XINCREF(kadmin);
return kadmin;
}
--
GitLab