Misc. fixes
Small fixes to comments, docstrings and function signatures. I thought it would be dumb to open a separate issue for each of these, so I packaged them all into one merge request. Maybe I should just push straight to develop next time?
Merge request reports
Activity
35 35 self._output_ports = [OutputPort(0, self)] 36 36 self._parameters["value"] = value 37 37 38 def evaluate(self) -> Any: 
It is superfluous since Any is the default return type annotation. In most cases, it would have made sense to keep it anyway for clarity, but in this case I believe it makes the user code cleaner if they don't have to add "Any" to everything since the signature for the evaluate method is completely generic (generic number of arguments, generic types of arguments and generic return type).
In other words, I would rather have the user manual say something like "overload evaluate by writing def evaluate(a, b): return a + b" instead of "overload evaluate by writing def evaluate(a: Any, b: Any) -> Any: return a + b", since I believe the latter would only be more confusing.
Edited by Ivar HärnqvistIf we don't type "Any" then there is no clear way to distinguish if the type is meant to be "Any" or if the developer forgot the typing, which I am sure will happen many times in this project considering that we are 8 developers. Don't you agree?
Also, don't we require 2 approvals to merge to develop? I can only see that Kevin approved this. You also merged the branch before waiting for a response on the comment / it being resolved which is not the type of code reviews that we want to have. I know this is a very minor issue but there are good reasons to keep these practices in place.
mentioned in commit c11f17f9
