Resolve "Refactor/minimize editor code"

Closes #118 (closed)

server/app/apis/questions.py

@@ -21,39 +21,39 @@ class QuestionList(Resource):
         return list_response(list_schema.dump(items))
 
 
-@api.route("/slides/<SID>/questions")
-@api.param("competition_id, SID")
+@api.route("/slides/<slide_order>/questions")
+@api.param("competition_id, slide_order")
 class QuestionListForSlide(Resource):
     @check_jwt(editor=True)
-    def post(self, SID, competition_id):
+    def post(self, slide_order, competition_id):
         args = question_parser.parse_args(strict=True)
         del args["slide_id"]
 
-        item_slide = dbc.get.slide(competition_id, SID)
+        item_slide = dbc.get.slide(competition_id, slide_order)
         item = dbc.add.question(item_slide=item_slide, **args)
 
         return item_response(schema.dump(item))
 
 
-@api.route("/slides/<SID>/questions/<QID>")
-@api.param("competition_id, SID, QID")
+@api.route("/slides/<slide_order>/questions/<QID>")
+@api.param("competition_id, slide_order, QID")
 class QuestionById(Resource):
     @check_jwt(editor=True)
-    def get(self, competition_id, SID, QID):
-        item_question = dbc.get.question(competition_id, SID, QID)
+    def get(self, competition_id, slide_order, QID):
+        item_question = dbc.get.question(competition_id, slide_order, QID)
         return item_response(schema.dump(item_question))
 
     @check_jwt(editor=True)
-    def put(self, competition_id, SID, QID):
+    def put(self, competition_id, slide_order, QID):
         args = question_parser.parse_args(strict=True)
 
-        item_question = dbc.get.question(competition_id, SID, QID)
+        item_question = dbc.get.question(competition_id, slide_order, QID)
         item_question = dbc.edit.question(item_question, **args)
 
         return item_response(schema.dump(item_question))
 
     @check_jwt(editor=True)
-    def delete(self, competition_id, SID, QID):
-        item_question = dbc.get.question(competition_id, SID, QID)
+    def delete(self, competition_id, slide_order, QID):
+        item_question = dbc.get.question(competition_id, slide_order, QID)
         dbc.delete.question(item_question)
         return {}, codes.NO_CONTENT