Skip to content
Snippets Groups Projects

Changed the \includearticle command.

Closed Ola Leifler requested to merge includearticle into master

Problem: The current implementation forced the pdf file to be put in the root folder, and the file to be named identically to the citekey. This was implemented in the includearticle macro. The includearticle macro also forced centering withou alignment of the output from \fullcite. This is preferable for text in general on otherwise blank pages, but looked rather ill formatted for a citation.

This commit simply separates the argument of file path and citekey to two separate arguments in \includearticle. The optional pages parameter is also added to the README.md. This was undocumented before and is good. Often, papers have a cover page with metadata content from the publisher. To alleviate the output from \fullcite, this commit puts the citation in a flushleft environment for alignment. This means it is still centered, but left aligned.

Merge request reports

Approval is optional

Closed by Ola LeiflerOla Leifler 4 years ago (Apr 7, 2020 1:53pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This is a good idea in general, but I would just like two additions:

    • Make sure includearticle and includearticletex behave the same way wrt arguments.
    • Update the documentation to properly reflect the signature of the revised macros, so that both the optional first argument is highlighted as well as the two arguments.

    By Ola Leifler on 2018-10-01T14:47:34 (imported from GitLab project)

  • closed

    By Gitlab user manager on 2020-04-07T13:53:29 (imported from GitLab project)

Please register or sign in to reply
Loading