Skip to content
Snippets Groups Projects

Resolve "Fix feedback from melpa maintainers"

Merged David Byers requested to merge 8-fix-feedback-from-melpa-maintainers into master
1 file
+ 10
11
Compare changes
  • Side-by-side
  • Inline
+ 10
11
@@ -3,7 +3,7 @@
@@ -3,7 +3,7 @@
;; Copyright (C) 2020 David Byers
;; Copyright (C) 2020 David Byers
;;
;;
;; Author: David Byers <david.byers@liu.se>
;; Author: David Byers <david.byers@liu.se>
;; Version: 1.4.0
;; Version: 1.4.1
;; Package-Requires: ((emacs "25.1"))
;; Package-Requires: ((emacs "25.1"))
;; Keywords: extensions, lisp
;; Keywords: extensions, lisp
;; URL: https://gitlab.liu.se/davby02/olc
;; URL: https://gitlab.liu.se/davby02/olc
@@ -45,12 +45,11 @@
@@ -45,12 +45,11 @@
(require 'request nil t)
(require 'request nil t)
(require 'json nil t)
(require 'json nil t)
;; Silence compiler if request is not on load-path at compile time
;; Silence compiler if request is not on load-path at compile time.
;; Unfortunately check-declare can't handle these.
(declare-function request "request")
(declare-function request "ext: request" t t)
(declare-function request-response-status-code "request")
(declare-function request-response-status-code "ext: request" t t)
(declare-function request-response-data "request")
(declare-function request-response-data "ext: request" t t)
;;; Variables:
;;; Variables:
@@ -175,7 +174,7 @@
@@ -175,7 +174,7 @@
(lonhi nil :read-only t))
(lonhi nil :read-only t))
(defsubst olc-area-lat (area)
(defsubst olc-area-lat (area)
"Get center latitute of AREA."
"Get center latitude of AREA."
(min (+ (/ (- (olc-area-lathi area) (olc-area-latlo area)) 2)
(min (+ (/ (- (olc-area-lathi area) (olc-area-latlo area)) 2)
(olc-area-latlo area))
(olc-area-latlo area))
90))
90))
@@ -403,7 +402,7 @@ space character is a valid code)."
@@ -403,7 +402,7 @@ space character is a valid code)."
(cl-defun olc-is-short (code &key compound)
(cl-defun olc-is-short (code &key compound)
"Return non-nil if CODE is a valid short open location code.
"Return non-nil if CODE is a valid short open location code.
If compound is non-nil, then return non-nil if CODE looks like a
If COMPOUND is non-nil, then return non-nil if CODE looks like a
compound open location code (i.e. everything up to the first
compound open location code (i.e. everything up to the first
space character is a valid short code).
space character is a valid short code).
@@ -751,9 +750,9 @@ LONGITUDE) representing the center of the location."
@@ -751,9 +750,9 @@ LONGITUDE) representing the center of the location."
;; Process code and check ref
;; Process code and check ref
(cond ((string-match "^\\(\\S-+\\)\\s-+\\(.*\\)$" code)
(cond ((string-match "^\\(\\S-+\\)\\s-+\\(.*\\)$" code)
(progn (cl-check-type ref null)
(cl-check-type ref null)
(setq ref (match-string 2 code)
(setq ref (match-string 2 code)
code (match-string 1 code))))
code (match-string 1 code)))
((olc-is-full code))
((olc-is-full code))
(t (cl-check-type ref stringp)))
(t (cl-check-type ref stringp)))
Loading