Packaging cleanup

CHANGELOG

 2020-07-22  David Byers  <david.byers@liu.se>
 
+	Fix test cases:
+	* test/olctest.el: Use keyword args in test cases.
+
+	Clean up for melpa:
+	* olc.el: Use #' instead of ' in a few places. Enable lexical
+	binding.
+
 	Rename some functions:
 	* olc.el (olc-shorten-compound): Renamed from olc-shorten-geo to
 	better match Google's terminology in their plus codes api.

olc.el

-;;  -*-coding: utf-8;-*-
-
-;;; olc.el --- Open location code library
+;;; olc.el --- Open location code library -*-lexical-binding: t;-*-
 
 ;; Copyright (C) 2020 David Byers
 ;;
@@ -350,7 +348,7 @@ values cannot (legally) be encoded to the selected length."
               (nconc (make-list (max 0 (- 8 len)) ?0)
                      (when truncate (list ?+)))))
 
-    (apply 'string code)))
+    (apply #'string code)))
 
 
 (defun olc-decode (code)
@@ -476,7 +474,7 @@ faster.
                                   (lon . ,(olc-area-lon area))
                                   (zoom . ,zoom)
                                   (format . "json"))
-                        :parser 'json-read
+                        :parser #'json-read
                         :sync t)))
                (tmp-code
                 (when resp
@@ -576,7 +574,7 @@ full open location code."
                   :params `((q . ,reference)
                             (format . "json")
                             (limit . 1))
-                  :parser 'json-read
+                  :parser #'json-read
                   :sync t)))
       (when (eq 200 (request-response-status-code resp))
         (let ((data (elt (request-response-data resp) 0)))

test/olctest.el

-;;;; -*-coding: utf-8;-*-
+;;;; -*-coding: utf-8; lexical-binding: t;-*-
 ;;;;
 ;;;; Copyright (C) 2020 David Byers
 ;;;;
@@ -112,7 +112,7 @@
   (olctest-run-csv ("encoding.csv" case)
     (let ((code (olc-encode (alist-get 'latitude case)
                             (alist-get 'longitude case)
-                            (alist-get 'length case))))
+                            :len (alist-get 'length case))))
       (unless (string= code (alist-get 'expected case))
         (olctest-record-failure case (alist-get 'expected case) code)))))
 
@@ -190,14 +190,14 @@
            (lon (alist-get 'lon case))
            (len (alist-get 'len case))
            (shortcode (alist-get 'exp case))
-           (actual (olc-shorten fullcode lat lon len)))
+           (actual (olc-shorten fullcode lat lon :limit len)))
       (unless (string= actual shortcode)
         (olctest-record-failure case shortcode actual)))))
 
 
 (defun olctest-run-all ()
   "Run all tests."
-  (and (olctest-decode)q
+  (and (olctest-decode)
        (olctest-encode)
        (olctest-shortcodes)
        (olctest-validity)