Skip to content
Snippets Groups Projects

Fixed ALU bugs of edit state and add breakpoint

1 unresolved thread

removed the ability to edit states and add breakpoints to modules that dont have anything but their names in their state

Closes #69

Merge request reports

Pipeline #133425 failed

Test coverage 34.59% (11.94%) from 3 jobs
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
291 291
292 # Create action to add breakpoint i items module
293 state_br_action = QAction('Add breakpoint', self)
294 state_br_action.triggered.connect(self.stateBreakpointDialog)
295 self.actions.append(state_br_action)
296
297 # Create action to edit items module
298 edit_state_action = QAction('Edit module state', self)
299 edit_state_action.triggered.connect(self.editModuleStateDialog)
300 self.actions.append(edit_state_action)
292 # Create action to edit items and add breakpoint only if the module
293 # has a state that contains any information
294 # (All states have a name, they need 2 or more to be editable)
295
296 module_state = self.module.get_state()
297 if len(module_state.keys()) > 1:
  • Comment on lines +296 to +297

    I propose moving "name" to parameters instead as the name should not really be part of the module state. Then this can be a check if there are any state variables instead.

  • Tbh the gui is such a mess that i dont want to get it work. We will most likely rewrite everything anyway and finding all places the code base where i need to replace state["name"] with parameter["name"] takes to much time.

    I can merge main into this branch after we rework the gui and then merge this into main

  • Please register or sign in to reply
  • Johannes Kung approved this merge request

    approved this merge request

  • Agree, will fix this later

  • added 1 commit

    • 6e517c6b - moved name from state to parameter and updated/added tests

    Compare with previous version

  • Martin Högstedt reset approvals from @johku144 by pushing to the branch

    reset approvals from @johku144 by pushing to the branch

  • added 1 commit

    • 5e890e8f - fixed broken gui by replacing get_state with get_gui_state where needed

    Compare with previous version

  • Johannes Kung approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading