Fixed ALU bugs of edit state and add breakpoint
Open
requested to merge 69-mai-alu-add-breakpoint-and-edit-module-actions-that-crash-the-program into main
1 unresolved thread
removed the ability to edit states and add breakpoints to modules that dont have anything but their names in their state
Closes #69
Merge request reports
Activity
Filter activity
added Bug label
assigned to @johku144
291 291 292 # Create action to add breakpoint i items module 293 state_br_action = QAction('Add breakpoint', self) 294 state_br_action.triggered.connect(self.stateBreakpointDialog) 295 self.actions.append(state_br_action) 296 297 # Create action to edit items module 298 edit_state_action = QAction('Edit module state', self) 299 edit_state_action.triggered.connect(self.editModuleStateDialog) 300 self.actions.append(edit_state_action) 292 # Create action to edit items and add breakpoint only if the module 293 # has a state that contains any information 294 # (All states have a name, they need 2 or more to be editable) 295 296 module_state = self.module.get_state() 297 if len(module_state.keys()) > 1: Tbh the gui is such a mess that i dont want to get it work. We will most likely rewrite everything anyway and finding all places the code base where i need to replace state["name"] with parameter["name"] takes to much time.
I can merge main into this branch after we rework the gui and then merge this into main
added 1 commit
- 6e517c6b - moved name from state to parameter and updated/added tests
reset approvals from @johku144 by pushing to the branch
added 1 commit
- 5e890e8f - fixed broken gui by replacing get_state with get_gui_state where needed
Please register or sign in to reply