Skip to content
  • Thomas Bellman's avatar
    90428d2d
    Handle syslog server with multiple addresses. · 90428d2d
    Thomas Bellman authored
    When we refactored the setup of sending syslogs to a central syslog
    server, we intended for the code to handle the case where the name of
    the server resolved to multiple addresses, e.g. because it had both
    IPv4 and IPv6 addresses.  We obviously did not test that properly, as
    setting the ipfamily parameter of logging::syslog_client to list both
    families, caused it to write "130.236.101.112001:6b0:17:1::1:11" to
    the rsyslog configuration; that's what you get when trying to format
    a list ["130.236.101.11", "2001:6b0:17:1::1:11"] (the current addresses
    of our central log server) using sprintf %s...
    
    The proper thing to do is to just pick the first address returned by
    resolve_ipnets().  Do so.
    
    This was originally commit e1f2d29570c0 in intserv.
    90428d2d
    Handle syslog server with multiple addresses.
    Thomas Bellman authored
    When we refactored the setup of sending syslogs to a central syslog
    server, we intended for the code to handle the case where the name of
    the server resolved to multiple addresses, e.g. because it had both
    IPv4 and IPv6 addresses.  We obviously did not test that properly, as
    setting the ipfamily parameter of logging::syslog_client to list both
    families, caused it to write "130.236.101.112001:6b0:17:1::1:11" to
    the rsyslog configuration; that's what you get when trying to format
    a list ["130.236.101.11", "2001:6b0:17:1::1:11"] (the current addresses
    of our central log server) using sprintf %s...
    
    The proper thing to do is to just pick the first address returned by
    resolve_ipnets().  Do so.
    
    This was originally commit e1f2d29570c0 in intserv.
Loading