From 8a851ee3d9b6ff1751a154c54e6c66cae25d038a Mon Sep 17 00:00:00 2001
From: jordanbreen28 <jordan.breen@perforce.com>
Date: Mon, 5 Jun 2023 13:32:27 +0100
Subject: [PATCH] (maint) - Update fixtures/modules path for .gitignore

Prior to this commit, the path supplied to .gitignore for
spec/fixtures/modules/ did not allow for manual unsetting of certain
file paths and therefore the check:gitignore check for linter threw an
error. "File specified in .gitignore has been committed"

To give more context, take the puppetlabs-node_encrypt module. The
node_encrypt module defines a module called "redact" within
spec/fixtures/modules/redact/, and this is required for spec testing.
However, once the `bundle exec rake syntax lint check:git_ignore`
command is run, we get the error seen above.

This commit alters the required path added to the .gitignore of the
puppet modules, but does not alter its core behaviour. (it will still
ignore all files under /spec/fixtures/modules), however now we can pass
additional paths to exclude from .gitignore (i.e.
spec/fixtures/modules/redact/) in our .sync.yml.
---
 config_defaults.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config_defaults.yml b/config_defaults.yml
index 5d3eb87..2d2cb17 100644
--- a/config_defaults.yml
+++ b/config_defaults.yml
@@ -28,7 +28,7 @@ common:
     - '/log/'
     - '/pkg/'
     - '/spec/fixtures/manifests/'
-    - '/spec/fixtures/modules/'
+    - '/spec/fixtures/modules/*'
     - '/tmp/'
     - '/vendor/'
     - '/convert_report.txt'
-- 
GitLab