From 26d4737a5d503138ae060d5b048e43d641071e5d Mon Sep 17 00:00:00 2001 From: apriestman <apriestman@basistech.com> Date: Fri, 18 Aug 2023 09:17:45 -0400 Subject: [PATCH] Sonarqube --- bindings/java/src/org/sleuthkit/datamodel/HostManager.java | 2 +- bindings/java/src/org/sleuthkit/datamodel/SlackFile.java | 2 +- .../java/src/org/sleuthkit/datamodel/SleuthkitCase.java | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bindings/java/src/org/sleuthkit/datamodel/HostManager.java b/bindings/java/src/org/sleuthkit/datamodel/HostManager.java index d8255b2e7..fb8d2eda0 100755 --- a/bindings/java/src/org/sleuthkit/datamodel/HostManager.java +++ b/bindings/java/src/org/sleuthkit/datamodel/HostManager.java @@ -295,7 +295,7 @@ public List<DataSource> getDataSourcesForHost(Host host) throws TskCoreException return dataSources; } catch (SQLException | TskDataException ex) { - throw new TskCoreException(String.format("Error getting data sources for host " + host.getName()), ex); + throw new TskCoreException(String.format("Error getting data sources for host %s", host.getName()), ex); } finally { db.releaseSingleUserCaseReadLock(); } diff --git a/bindings/java/src/org/sleuthkit/datamodel/SlackFile.java b/bindings/java/src/org/sleuthkit/datamodel/SlackFile.java index e6bf7c4e0..f53f63aa7 100644 --- a/bindings/java/src/org/sleuthkit/datamodel/SlackFile.java +++ b/bindings/java/src/org/sleuthkit/datamodel/SlackFile.java @@ -117,7 +117,7 @@ public class SlackFile extends FsContent { */ @Override @SuppressWarnings("deprecation") - protected int readInt(byte[] buf, long offset, long len) throws TskCoreException { + protected synchronized int readInt(byte[] buf, long offset, long len) throws TskCoreException { if (offset == 0 && size == 0) { //special case for 0-size file return 0; diff --git a/bindings/java/src/org/sleuthkit/datamodel/SleuthkitCase.java b/bindings/java/src/org/sleuthkit/datamodel/SleuthkitCase.java index c04094367..5cbde51ec 100644 --- a/bindings/java/src/org/sleuthkit/datamodel/SleuthkitCase.java +++ b/bindings/java/src/org/sleuthkit/datamodel/SleuthkitCase.java @@ -10090,16 +10090,16 @@ public void setImagePaths(long obj_id, List<String> paths) throws TskCoreExcepti * within tsk core and the update fails */ @Beta - public void setImagePaths(long obj_id, List<String> paths, CaseDbTransaction trans) throws TskCoreException { + public void setImagePaths(long objId, List<String> paths, CaseDbTransaction trans) throws TskCoreException { try { PreparedStatement statement = trans.getConnection().getPreparedStatement(PREPARED_STATEMENT.DELETE_IMAGE_NAME); statement.clearParameters(); - statement.setLong(1, obj_id); + statement.setLong(1, objId); trans.getConnection().executeUpdate(statement); for (int i = 0; i < paths.size(); i++) { statement = trans.getConnection().getPreparedStatement(PREPARED_STATEMENT.INSERT_IMAGE_NAME); statement.clearParameters(); - statement.setLong(1, obj_id); + statement.setLong(1, objId); statement.setString(2, paths.get(i)); statement.setLong(3, i); trans.getConnection().executeUpdate(statement); -- GitLab