diff --git a/bindings/java/jni/dataModel_SleuthkitJNI.cpp b/bindings/java/jni/dataModel_SleuthkitJNI.cpp index 3d17438dc4c5ebc163f5c682aef6d26accd92d0b..6e05f3059abb4d39aa25bae2600c740c74610850 100644 --- a/bindings/java/jni/dataModel_SleuthkitJNI.cpp +++ b/bindings/java/jni/dataModel_SleuthkitJNI.cpp @@ -320,15 +320,15 @@ JNIEXPORT jint JNICALL */ JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbBeginTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle) + JNIEnv *env, jclass obj, jint dbHandle) { - if((size_t) dbHandle > hashDbs.size()) { + if((size_t)dbHandle > hashDbs.size()) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } - TSK_HDB_INFO * db = hashDbs.at(dbHandle-1); - if(!db) { + TSK_HDB_INFO *db = hashDbs.at(dbHandle - 1); + if (!db) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } @@ -345,15 +345,15 @@ Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbBeginTransactionNat( */ JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbCommitTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle) + JNIEnv *env, jclass obj, jint dbHandle) { - if((size_t) dbHandle > hashDbs.size()) { + if((size_t)dbHandle > hashDbs.size()) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } - TSK_HDB_INFO * db = hashDbs.at(dbHandle-1); - if(!db) { + TSK_HDB_INFO *db = hashDbs.at(dbHandle - 1); + if (!db) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } @@ -370,15 +370,15 @@ Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbCommitTransactionNat( */ JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbRollbackTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle) + JNIEnv *env, jclass obj, jint dbHandle) { - if((size_t) dbHandle > hashDbs.size()) { + if((size_t)dbHandle > hashDbs.size()) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } - TSK_HDB_INFO * db = hashDbs.at(dbHandle-1); - if(!db) { + TSK_HDB_INFO *db = hashDbs.at(dbHandle-1); + if (!db) { setThrowTskCoreError(env, "Invalid database handle"); return 1; } diff --git a/bindings/java/jni/dataModel_SleuthkitJNI.h b/bindings/java/jni/dataModel_SleuthkitJNI.h index bfdd3eb45b383d76d0266ec604e76e7bfbf7fcd0..03c3ad83187c2fa344793da19da644a4646a9ece 100644 --- a/bindings/java/jni/dataModel_SleuthkitJNI.h +++ b/bindings/java/jni/dataModel_SleuthkitJNI.h @@ -67,15 +67,15 @@ JNIEXPORT jint JNICALL JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbBeginTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle); + JNIEnv *env, jclass obj, jint dbHandle); JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbCommitTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle); + JNIEnv *env, jclass obj, jint dbHandle); JNIEXPORT jint JNICALL Java_org_sleuthkit_datamodel_SleuthkitJNI_hashDbRollbackTransactionNat( - JNIEnv * env, jclass obj, jint dbHandle); + JNIEnv *env, jclass obj, jint dbHandle); /* * Class: org_sleuthkit_datamodel_SleuthkitJNI diff --git a/bindings/java/src/org/sleuthkit/datamodel/HashEntry.java b/bindings/java/src/org/sleuthkit/datamodel/HashEntry.java index fa1459f01c7c3a6be7ccc5c203ecf255df12497b..781a6ac544158fe72782b59d59390fefeae40b12 100755 --- a/bindings/java/src/org/sleuthkit/datamodel/HashEntry.java +++ b/bindings/java/src/org/sleuthkit/datamodel/HashEntry.java @@ -22,10 +22,10 @@ * Used to pass hashDb information about a particular file from TSK to Autopsy */ public class HashEntry { + private String fileName; private String md5Hash; private String sha1Hash; private String sha256Hash; - private String fileName; private String comment; public HashEntry(String fileName, String md5Hash, String sha1Hash, String sha256Hash, String comment) { @@ -36,6 +36,10 @@ public HashEntry(String fileName, String md5Hash, String sha1Hash, String sha256 this.comment = comment; } + public String getFileName() { + return fileName; + } + public String getMd5Hash() { return md5Hash; } @@ -48,10 +52,6 @@ public String getSha256Hash() { return sha256Hash; } - public String getFileName() { - return fileName; - } - public String getComment() { return comment; } diff --git a/bindings/java/src/org/sleuthkit/datamodel/SleuthkitJNI.java b/bindings/java/src/org/sleuthkit/datamodel/SleuthkitJNI.java index f35c73ad4b5bb9f3b10b295fc4cfefe5b34c1c15..62d800738bdef0c9d84a448980df9c726f9cfed3 100644 --- a/bindings/java/src/org/sleuthkit/datamodel/SleuthkitJNI.java +++ b/bindings/java/src/org/sleuthkit/datamodel/SleuthkitJNI.java @@ -56,9 +56,9 @@ public class SleuthkitJNI { private static native int hashDbNewNat(String hashDbPath) throws TskCoreException; private static native int hashDbBeginTransactionNat(int dbHandle) throws TskCoreException; - + private static native int hashDbCommitTransactionNat(int dbHandle) throws TskCoreException; - + private static native int hashDbRollbackTransactionNat(int dbHandle) throws TskCoreException; private static native int hashDbAddEntryNat(String filename, String hashMd5, String hashSha1, String hashSha256, String comment, int dbHandle) throws TskCoreException; diff --git a/tsk/hashdb/sqlite_hdb.cpp b/tsk/hashdb/sqlite_hdb.cpp index c5bb2026ebb8e8461f44fb2ce7a5e2ff0e578c1a..e57ada9c20cc723c698860bf9a9855fe4800a666 100644 --- a/tsk/hashdb/sqlite_hdb.cpp +++ b/tsk/hashdb/sqlite_hdb.cpp @@ -669,7 +669,7 @@ uint8_t sqlite_hdb_begin_transaction(TSK_HDB_INFO *hdb_info_base) TSK_SQLITE_HDB_INFO *hdb_info = reinterpret_cast<TSK_SQLITE_HDB_INFO*>(hdb_info_base); if (sqlite_hdb_attempt_exec("BEGIN", "sqlite_hdb_base_begin_transaction: %s\n", hdb_info->db)) { return 1; - } + } else { return 0; } @@ -685,9 +685,9 @@ uint8_t sqlite_hdb_begin_transaction(TSK_HDB_INFO *hdb_info_base) uint8_t sqlite_hdb_commit_transaction(TSK_HDB_INFO *hdb_info_base) { TSK_SQLITE_HDB_INFO *hdb_info = reinterpret_cast<TSK_SQLITE_HDB_INFO*>(hdb_info_base); - if (sqlite_hdb_attempt_exec("COMMIT", "sqlite_hdb_base_end_transaction: %s\n", hdb_info->db)) { + if (sqlite_hdb_attempt_exec("COMMIT", "sqlite_hdb_commit_transaction: %s\n", hdb_info->db)) { return 1; - } + } else { return 0; } @@ -703,7 +703,7 @@ uint8_t sqlite_hdb_commit_transaction(TSK_HDB_INFO *hdb_info_base) uint8_t sqlite_hdb_rollback_transaction(TSK_HDB_INFO *hdb_info_base) { TSK_SQLITE_HDB_INFO *hdb_info = reinterpret_cast<TSK_SQLITE_HDB_INFO*>(hdb_info_base); - if (sqlite_hdb_attempt_exec("ROLLBACK", "sqlite_hdb_base_end_transaction: %s\n", hdb_info->db)) { + if (sqlite_hdb_attempt_exec("ROLLBACK", "sqlite_hdb_rollback_transaction: %s\n", hdb_info->db)) { return 1; } else {