From bd8cd5bcd63d3b72da7da04a15b71398e7d74e4f Mon Sep 17 00:00:00 2001
From: marho227 <marho227@student.liu.se>
Date: Fri, 14 Jun 2024 11:34:07 +0200
Subject: [PATCH] made private things private
---
.../module_graphics_item/memory_graphic.py | 27 +++++++++----------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/simudator/gui/module_graphics_item/memory_graphic.py b/src/simudator/gui/module_graphics_item/memory_graphic.py
index ca4533e..e1dc00b 100644
--- a/src/simudator/gui/module_graphics_item/memory_graphic.py
+++ b/src/simudator/gui/module_graphics_item/memory_graphic.py
@@ -29,23 +29,20 @@ class MemoryWindow(QTableWidget):
memory_module: An instance of the Memory base class.
column_size: An integer specifying the number of columns, optional.
- Attributes
- ----------
- memory_size: The number of memory addresses.
"""
def __init__(self, memory_module: Memory, column_size=-1):
super().__init__()
- self.memory = memory_module
- self.column_size = column_size
- self.memory_size = len(self.memory.get_state()["memory"])
+ self._memory = memory_module
+ self._column_size = column_size
+ self._memory_size = len(self.memory.get_state()["memory"])
self._set_column_size()
- self.setColumnCount(self.column_size)
- self.setRowCount(ceil(self.memory_size / self.column_size))
+ self.setColumnCount(self._column_size)
+ self.setRowCount(ceil(self.memory_size / self._column_size))
self.setHorizontalHeaderLabels(["+" + str(i) for i in range(4)])
vertical_headers = []
- for i in range(0, self.memory_size, self.column_size):
+ for i in range(0, self.memory_size, self._column_size):
vertical_headers.append(str(hex(i)))
self.setVerticalHeaderLabels(vertical_headers)
@@ -59,8 +56,8 @@ class MemoryWindow(QTableWidget):
memory_content = self.memory.get_state()["memory"]
for i in range(self.memory_size):
value = memory_content[i]
- row = i // self.column_size
- col = i % self.column_size
+ row = i // self._column_size
+ col = i % self._column_size
self.set_item(row, col, str(value))
def set_item(self, row: int, col: int, text: str) -> None:
@@ -86,18 +83,18 @@ class MemoryWindow(QTableWidget):
This function assumes that the attributes `column_size` and `memory_size` are set before it is called.
"""
- if not self.column_size == -1:
+ if not self._column_size == -1:
return
if self.memory_size > 200:
- self.column_size = 4
+ self._column_size = 4
return
if self.memory_size > 100:
- self.column_size = 2
+ self._column_size = 2
return
- self.column_size = 1
+ self._column_size = 1
return
--
GitLab