From 10976d007f4fb7ab7b58f3ecc56874b9a0f3d412 Mon Sep 17 00:00:00 2001
From: angloth <angus.lothian@hotmail.com>
Date: Wed, 18 Mar 2020 15:36:05 +0100
Subject: [PATCH] Solve pull request comments and change so evaluate function
in SFG uses the same interface as the abstract evaluate function
---
b_asic/abstract_operation.py | 1 +
b_asic/signal_flow_graph.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/b_asic/abstract_operation.py b/b_asic/abstract_operation.py
index 8aed92a4..68b3c02a 100644
--- a/b_asic/abstract_operation.py
+++ b/b_asic/abstract_operation.py
@@ -14,6 +14,7 @@ from b_asic.simulation import SimulationState, OperationState
from b_asic.utilities import breadth_first_search
from b_asic.signal import Signal
+
class AbstractOperation(Operation, AbstractGraphComponent):
"""Generic abstract operation class which most implementations will derive from.
TODO: More info.
diff --git a/b_asic/signal_flow_graph.py b/b_asic/signal_flow_graph.py
index ab2c3e94..f59a246d 100644
--- a/b_asic/signal_flow_graph.py
+++ b/b_asic/signal_flow_graph.py
@@ -46,7 +46,7 @@ class SFG(AbstractOperation):
# TODO: Traverse the graph between the inputs/outputs and add to self._operations.
# TODO: Connect ports with signals with appropriate IDs.
- def evaluate(self, inputs: list) -> list:
+ def evaluate(self, *inputs) -> list:
return [] # TODO: Implement
def _add_graph_component(self, graph_component: GraphComponent) -> GraphID:
--
GitLab