From a7cced2f0cb915d2f9aedb9a04fc58cde6ec368e Mon Sep 17 00:00:00 2001
From: "Alexander \"Ace\" Olofsson" <ace@haxalot.com>
Date: Thu, 28 Feb 2019 17:08:08 +0100
Subject: [PATCH] Fix Rubocop issues
---
.rubocop.yml | 7 +++++++
lib/matrix_sdk/api.rb | 2 +-
lib/matrix_sdk/application_service.rb | 2 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/.rubocop.yml b/.rubocop.yml
index 4dc7a81..600262e 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -8,6 +8,9 @@ AllCops:
Lint/Void:
Enabled: false
+Style/ClassAndModuleChildren:
+ Enabled: false
+
# Don't enforce documentation
Style/Documentation:
Enabled: false
@@ -18,6 +21,10 @@ Metrics/ClassLength:
Metrics/MethodLength:
Max: 50
+# Matrix has a lot of methods in the CS API
+Metrics/ModuleLength:
+ Max: 500
+
Metrics/LineLength:
Max: 190
diff --git a/lib/matrix_sdk/api.rb b/lib/matrix_sdk/api.rb
index ef1254d..d874aa7 100644
--- a/lib/matrix_sdk/api.rb
+++ b/lib/matrix_sdk/api.rb
@@ -42,7 +42,7 @@ module MatrixSdk
@protocols = params.fetch(:protocols, %i[CS])
@protocols = [@protocols] unless @protocols.is_a? Array
@protocols << :CS if @protocols.include?(:AS) && !@protocols.include?(:CS)
- @protocols.sort.reverse.each do |prot|
+ @protocols.sort.reverse_each do |prot|
extend MatrixSdk::Protocols.const_get(prot)
end
diff --git a/lib/matrix_sdk/application_service.rb b/lib/matrix_sdk/application_service.rb
index 7a221c6..c978765 100644
--- a/lib/matrix_sdk/application_service.rb
+++ b/lib/matrix_sdk/application_service.rb
@@ -58,6 +58,7 @@ module MatrixSdk
def port=(port)
raise ArgumentError, 'Port must be a number' unless port.is_a? Numeric
+
@port = port
end
@@ -66,6 +67,7 @@ module MatrixSdk
def add_method(method, regex, proc = nil, &block)
proc ||= block
raise ArgumentError, 'No method specified' if proc.nil?
+
(@method_map[method] ||= {})[regex] = proc
end
--
GitLab