From e16cb376ad3393765d07e8545c9c76ae217eab42 Mon Sep 17 00:00:00 2001
From: Thomas Bellman <bellman@nsc.liu.se>
Date: Wed, 21 Aug 2019 12:13:14 +0200
Subject: [PATCH] Remove leftover assignment of a local variable.

When we reworked how to do the site configuration some weeks ago, we
also removed the default setting of the 'errorlogname' and 'tcpport'
options in dsm.sys.  However, we missed removing the assignment of a
local variable to those default settings in the tsmclient definition.
This variable was no longer referenced anywhere, so the leftover
assignment didn't actually affect anything, but it would of course
cause readers of the code to wonder what was going on.  Compilation
of manifests for a node would probably also take a tiny bit longer.

Remove this forgotten variable assignment.

Thanks to Hans Persson for noticing it.
---
 manifests/init.pp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/manifests/init.pp b/manifests/init.pp
index 5d9d046..4140d40 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -77,10 +77,6 @@ define tsmclient($serveraddress=undef, $nodename=$fqdn,
     $tsmdir = $tsmclient::vars::tsmdir
     $tsmpassworddir = $tsmclient::vars::tsmpassworddir
 
-    $sysoptions_defaults = [
-	'errorlogname   /var/log/dsmerror.log',
-	'tcpport        1500',
-    ]
     $tsm_servername = $name
     $tsm_nodename = $nodename
     $tsm_inclexcl = concat(
-- 
GitLab